Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused-imports/no-unused-imports for TSX files #28866

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Mar 4, 2025

Fix #28855


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@qmonmert qmonmert changed the title Remove unused-imports/no-unused-imports Remove unused-imports/no-unused-imports for TSX files Mar 5, 2025
@qmonmert qmonmert marked this pull request as ready for review March 5, 2025 21:43
@qmonmert qmonmert requested a review from mshima March 5, 2025 21:43
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried different approaches?
IMO it’s important to keep it.

@qmonmert
Copy link
Contributor Author

qmonmert commented Mar 6, 2025

@mshima not really, it was my first idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants