Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitLab CI Docker push job #27910

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

yhao3
Copy link
Contributor

@yhao3 yhao3 commented Nov 18, 2024

Description

This pull request includes the following changes:

  1. Remove the unnecessary REGISTRY_URL variable, as the predefined CI_REGISTRY can be used instead.
  2. Update the Docker push configuration to use the predefined CI_REGISTRY_USER and CI_REGISTRY_PASSWORD variables instead of "gitlab-ci-token" and CI_BUILD_TOKEN.
  3. Update comments to reflect changes and improve clarity.

@mraible
Copy link
Contributor

mraible commented Nov 18, 2024

It looks like you need to run npm run update-snapshots.

@yhao3
Copy link
Contributor Author

yhao3 commented Nov 19, 2024

Hi @mraible,

Thanks for the reminder! I’ve run npm run update-snapshots, and the CI build is now passing. Please let me know if there’s anything else I need to address.

@mraible mraible merged commit 35e2eb8 into jhipster:main Nov 19, 2024
30 checks passed
@mraible mraible added this to the 8.8.0 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants