Type safety - Incremental step 2 #26110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tcharl
commented
May 11, 2024
jdl/converters/jdl-to-json/jdl-with-applications-to-json-converter.spec.ts
Show resolved
Hide resolved
| relationshipSide?: RelationshipSide; | ||
| relationshipName: string; | ||
| relationshipType: RelationshipType; | ||
| otherEntityName: string; | ||
| options?: Record<string, boolean | string | number>; | ||
| } & Record<string, any>; | ||
|
|
||
| export type Entity = { | ||
| export type JSONEntity = { |
There was a problem hiding this comment.
I'm a bit confused with this one: what's the difference with generators/base-application/types/entity.d.ts? is it relevant that these converters/types exists?
There was a problem hiding this comment.
generators/base-application/types/entity.d.ts have calculated values and supported annotations.
They are used in generators.
In jdl and json only base data and annotations of type Record<any, any> exists.
Tcharl
commented
May 11, 2024
jdl/models/jdl-application.ts
Outdated
| @@ -24,12 +24,18 @@ import JDLApplicationConfigurationOption from './jdl-application-configuration-o | |||
| import JDLApplicationConfiguration from './jdl-application-configuration.js'; | |||
| import JDLApplicationEntities from './jdl-application-entities.js'; | |||
| import JDLOptions from './jdl-options.js'; | |||
| import AbstractJDLOption from './abstract-jdl-option.js'; | |||
|
|
|||
| export type JDLJSONApplicationConfiguration = { | |||
There was a problem hiding this comment.
Same confusion about the relevance: shouldn't it be jdl/models/jdl-application.ts. Is it worth splitting the business model and the JDLJson one?
mshima
approved these changes
May 11, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More type safety on JDL
Related with #26114
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.