Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https is deprecated so --ssl is now passing a server type #25969

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

henri-tremblay
Copy link
Contributor

config.devServer.https is deprecated so ng server --ssl is now passing config.devServer.server.type=https.

@mshima
Copy link
Member

mshima commented Apr 26, 2024

@henri-tremblay do you have some reference?

@henri-tremblay
Copy link
Contributor Author

About the deprecation? Actually, if you do /npmw run start-tls right now, you will see that it doesn't work. Also if you add config.devServer.https=true in webpack.custom.js you will see the deprecation message being printed. I think they did that because they now support spdy so it can't be a boolean anymore.

Here is an issue about the deprecation: webpack/webpack#14949

@mshima
Copy link
Member

mshima commented Apr 26, 2024

@mshima mshima merged commit e1cb0ee into jhipster:main Apr 26, 2024
39 checks passed
@mraible mraible added this to the 8.4.0 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants