Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move prompts to spring-boot generator #25888

Merged
merged 3 commits into from
Apr 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/angular.yml
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,9 @@ jobs:
#----------------------------------------------------------------------
- uses: jhipster/actions/compare-sample@v0
id: compare
if: >-
github.event.pull_request &&
!contains(github.event.pull_request.labels.*.name, 'pr: disable-compare')
with:
generator-path: generator-jhipster
cmd: jh generate-sample ${{ matrix.name }} --skip-jhipster-dependencies --skip-checks --skip-install --no-insight
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/react.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,9 @@ jobs:
with:
generator-path: generator-jhipster
cmd: jh generate-sample ${{ matrix.name }} --skip-jhipster-dependencies --skip-checks --skip-install --no-insight
if: >-
github.event.pull_request &&
!contains(github.event.pull_request.labels.*.name, 'pr: disable-compare')
env:
# generate-sample uses JHI_FOLDER_APP to generate the application.
JHI_FOLDER_APP: ${{ github.workspace }}/base/app
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/vue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ jobs:
generator-path: generator-jhipster
- name: 'GENERATION: project'
run: jh generate-sample ${{ matrix.name }} --skip-jhipster-dependencies --skip-checks --skip-install --no-insight
if: >-
github.event.pull_request &&
!contains(github.event.pull_request.labels.*.name, 'pr: disable-compare')
env:
JHI_FOLDER_APP: ${{ github.workspace }}/app
JHIPSTER_DEPENDENCIES_VERSION: ${{ matrix.jhipster-bom-cicd-version }}
Expand Down
4 changes: 0 additions & 4 deletions generators/server/generator.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ import {
getPrimaryKeyValue as getPKValue,
hibernateSnakeCase,
} from './support/index.js';
import { askForOptionalItems, askForServerSideOpts, askForServerTestOpts } from './prompts.js';

import { GENERATOR_COMMON, GENERATOR_SPRING_BOOT } from '../generator-list.js';
import BaseApplicationGenerator from '../base-application/index.js';
Expand Down Expand Up @@ -139,9 +138,6 @@ export default class JHipsterServerGenerator extends BaseApplicationGenerator {
if (control.existingProject && this.options.askAnswered !== true) return;
await this.promptCurrentJHipsterCommand();
},
askForServerTestOpts,
askForServerSideOpts,
askForOptionalItems,
});
}

Expand Down
4 changes: 4 additions & 0 deletions generators/spring-boot/generator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ import {
} from '../../jdl/index.js';
import { writeFiles as writeEntityFiles } from './entity-files.js';
import { getPomVersionProperties, parseMavenPom } from '../maven/support/index.js';
import { askForOptionalItems, askForServerSideOpts, askForServerTestOpts } from './prompts.js';

const { CAFFEINE, EHCACHE, HAZELCAST, INFINISPAN, MEMCACHED, REDIS, NO: NO_CACHE } = cacheTypes;
const { NO: NO_WEBSOCKET, SPRING_WEBSOCKET } = websocketTypes;
Expand Down Expand Up @@ -106,6 +107,9 @@ export default class SpringBootGenerator extends BaseApplicationGenerator {
if (control.existingProject && this.options.askAnswered !== true) return;
await this.promptCurrentJHipsterCommand();
},
askForServerTestOpts,
askForServerSideOpts,
askForOptionalItems,
});
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ import {
serviceDiscoveryTypes,
testFrameworkTypes,
} from '../../jdl/jhipster/index.js';
import { MESSAGE_BROKER } from './options/index.js';
import { R2DBC_DB_OPTIONS, SQL_DB_OPTIONS } from './support/database.js';
import { MESSAGE_BROKER } from '../server/options/index.js';
import { R2DBC_DB_OPTIONS, SQL_DB_OPTIONS } from '../server/support/database.js';

const { OptionNames } = applicationOptions;
const { GATEWAY, MICROSERVICE, MONOLITH } = applicationTypes;
Expand Down
Loading