-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create SpaWebFilterIT for reactive app #21041
Conversation
Hi @mraible, |
@frascu If I create
I get two test failures when running
If I run |
@frascu Do you see this same behavior if you create an app like I did? |
I see the same behavior. In addition, it seems that intellij has the same behavior of this github step. |
In the GitHub action, the command ./mvnw -ntp -Dskip.installnodenpm -Dskip.npm verify --batch-mode However, if the command is run without ./mvnw -ntp verify --batch-mode Therefore, in this commit In the end, other jobs fail due to an action timeout, which is not related to this issue. |
@mraible can this pull request be merged or should I change something? |
@frascu Can you please fix the conflicts? |
# Conflicts: # generators/server/files.mjs
Thanks @frascu |
Hi @DanielFran, |
@frascu approved |
When the app is reactive,
SpaWebFilter
mutates the request from a general url to/index.html
(here). It means that is not a forwarding like in the non-reactive app (here).Therefore, after the HTTP status assertion, it is not possible to assert the forwarded URL, only the Content Type.
Fixes #21003