fixes daily-build regressions related to npm scripts migration #18780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tcharl
reviewed
Jun 1, 2022
generators/server/index.js
Outdated
| @@ -459,6 +459,11 @@ module.exports = class JHipsterServerGenerator extends BaseBlueprintGenerator { | |||
| 'docker:db:await': `echo "Waiting for Couchbase to start" && wait-on -t ${WAIT_TIMEOUT} http-get://localhost:8091/ui/index.html && sleep 30 && echo "Couchbase started"`, | |||
| }); | |||
| } | |||
| if (prodDatabaseType === MYSQL) { | |||
There was a problem hiding this comment.
I guess that now we should also add this line if devDatabaseType is Mysql too.
Maybe a liveliness probe in the docker-compose file and in the TestContainer implementation would be more efficient than an additional command
There was a problem hiding this comment.
Testcontainer doesn’t have this problem.
Docker compose uses sleep at microservices.
A liveliness in entrypoint is nice but can be trick.
There was a problem hiding this comment.
I remember that I made some liveliness probes for some jh services in one of my previous project, let me check
DanielFran
requested changes
Jun 1, 2022
mshima
changed the title
mshima
changed the title
|
Please squash when merging. |
DanielFran
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes daily-build regressions related to npm scripts migration.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.