-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to mixed microservice/microfrontend. #18632
Conversation
@mshima What is the current behavior and how does this PR fix it? |
I tried installing this branch and generating apps with I'm still interested in having a way to run |
@mshima You still have 2 TODOs in the integration test samples: |
Before #18254, microservice entities and microfrontend entities were indistinguishable. With #18254, microfrontend entities don't need to be copied to the gateway anymore. So with this PR, microfrontend entities at the gateway |
@DanielFran they are bugs not related to this PR. |
@mraible need workspaces.
|
@mshima I'm trying to create a demo script for the microfrontends support that will eventually become a blog post. If I try the following:
It fails:
I thought this might be because I never started the apps, so I started all the dependent Docker containers (with gateway:
blog:
store:
Am I doing something wrong? |
|
Should I be able to run these at the top level with If I run
|
Top level without |
We do this at ci (microservices too): generator-jhipster/.github/workflows/angular.yml Lines 196 to 205 in 3ba8c95
|
I tried again with the
I used
I ran |
Indeed doesn't exists. Use
Have you created the top level repository manually? |
I have not created the top-level repository manually. Here are the commands I'm using:
|
I've forgot. Please use |
I tried them both. For the first one, I had to use For both commands, I see the following errors like the following when generating apps:
Same when building the Docker containers:
And when I try using the
|
@mshima I came up with the following demo script to showcase how microfrontends work with JHipster. Please let me know if there's anything you think I should add or remove:
FWIW, I tried these steps with the current Also, with steps 6 and 7, the browser loads with an error rather than showing the app. It took me a while to realize I could close the error with the X in the top right. The console log is kinda scary too. |
Before #18254 entities were required to link a gateway to microfrontends. For this reason, entities with microserviceName needed to be skipped.
This PR reenable microservices entities generation at gateway side (frontend) when microfrontend support is enabled.
This is a breaking change to existing microfrontend gateway applications.
Microfrontend entities need to be deleted from gateway’s
.jhipster
folder, otherwise the entities will have its frontend generated at gateway side.Related to #17031
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.