Update templates to get translations using new API #18423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mshima
requested changes
Apr 21, 2022
...r/src/main/webapp/app/account/password-reset/finish/password-reset-finish.component.html.ejs
Outdated
Show resolved
Hide resolved
...r/src/main/webapp/app/account/password-reset/finish/password-reset-finish.component.html.ejs
Outdated
Show resolved
Hide resolved
...r/src/main/webapp/app/admin/user-management/detail/user-management-detail.component.html.ejs
Outdated
Show resolved
Hide resolved
...rs/client/templates/angular/src/main/webapp/app/account/settings/settings.component.html.ejs
Outdated
Show resolved
Hide resolved
...rs/client/templates/angular/src/main/webapp/app/account/sessions/sessions.component.html.ejs
Outdated
Show resolved
Hide resolved
...gular/src/main/webapp/app/account/password-reset/init/password-reset-init.component.html.ejs
Outdated
Show resolved
Hide resolved
...rs/client/templates/angular/src/main/webapp/app/account/password/password.component.html.ejs
Outdated
Show resolved
Hide resolved
...rs/client/templates/angular/src/main/webapp/app/account/password/password.component.html.ejs
Outdated
Show resolved
Hide resolved
...rs/client/templates/angular/src/main/webapp/app/account/register/register.component.html.ejs
Outdated
Show resolved
Hide resolved
mshima
requested changes
Apr 21, 2022
generators/client/templates/angular/src/main/webapp/app/admin/health/health.component.html.ejs
Outdated
Show resolved
Hide resolved
generators/client/templates/angular/src/main/webapp/app/home/home.component.html.ejs
Outdated
Show resolved
Hide resolved
LalaRzayeva
force-pushed
the
issue-15964
branch
from
3e6645c to
31f237a
Compare
mshima
requested changes
Apr 22, 2022
...gular/src/main/webapp/app/entities/delete/entity-management-delete-dialog.component.html.ejs
Outdated
Show resolved
Hide resolved
...ates/angular/src/main/webapp/app/entities/detail/entity-management-detail.component.html.ejs
Outdated
Show resolved
Hide resolved
...ates/angular/src/main/webapp/app/entities/detail/entity-management-detail.component.html.ejs
Outdated
Show resolved
Hide resolved
...ent/templates/angular/src/main/webapp/app/entities/list/entity-management.component.html.ejs
Outdated
Show resolved
Hide resolved
generators/client/templates/angular/src/main/webapp/app/admin/health/health.component.html.ejs
Outdated
Show resolved
Hide resolved
...ates/angular/src/main/webapp/app/entities/update/entity-management-update.component.html.ejs
Outdated
Show resolved
Hide resolved
...s/client/templates/angular/src/main/webapp/app/layouts/profiles/page-ribbon.component.ts.ejs
Outdated
Show resolved
Hide resolved
mshima
reviewed
Apr 22, 2022
...ent/templates/angular/src/main/webapp/app/entities/list/entity-management.component.html.ejs
Outdated
Show resolved
Hide resolved
mshima
reviewed
Apr 22, 2022
...ates/angular/src/main/webapp/app/entities/detail/entity-management-detail.component.html.ejs
Outdated
Show resolved
Hide resolved
|
@mshima I removed the TODO comments from the translation, which you seem to have corrected, so there are only 6 comments left that require your attention. Maybe you could fix them yourself as it's still not clear to me what to do with them. |
mshima
reviewed
Apr 30, 2022
generators/client/templates/angular/src/main/webapp/app/admin/health/health.component.html.ejs
Outdated
Show resolved
Hide resolved
...s/client/templates/angular/src/main/webapp/app/layouts/profiles/page-ribbon.component.ts.ejs
Outdated
Show resolved
Hide resolved
...ates/angular/src/main/webapp/app/entities/update/entity-management-update.component.html.ejs
Outdated
Show resolved
Hide resolved
...ent/templates/angular/src/main/webapp/app/entities/list/entity-management.component.html.ejs
Outdated
Show resolved
Hide resolved
...ates/angular/src/main/webapp/app/entities/detail/entity-management-detail.component.html.ejs
Outdated
Show resolved
Hide resolved
...ates/angular/src/main/webapp/app/entities/update/entity-management-update.component.html.ejs
Outdated
Show resolved
Hide resolved
mshima
previously approved these changes
Apr 30, 2022
|
No clue why vue is failing coverage test. |
mshima
approved these changes
May 1, 2022
|
@LalaRzayeva thanks for your contribution, don't forget to claim the bounty. |
|
@DanielFran @pascalgrimaud this is a cool feature to be highlighted into release notes. |
|
Bug bounty claimed at https://opencollective.com/generator-jhipster/expenses/75300 |
|
@LalaRzayeva : approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15964
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.