Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node required version and add ignore conflicting packages version. #15837

Merged
merged 3 commits into from
Aug 4, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented Aug 4, 2021

Node 12.20.0 added stable esm module support.

  • Many dependencies will depend on it eg: chore(deps): bump insight from 0.10.3 to 0.11.0 #15794.
  • This allows to implement modular generator as mjs.
  • It's a minor node version bump, may or may not be considered a breaking change, in jhipster I don't consider a breaking change since we always generate package.json with latest lts node version.

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran DanielFran merged commit d1f6310 into jhipster:main Aug 4, 2021
@mshima mshima deleted the skip_ci-node12 branch August 4, 2021 20:29
@pascalgrimaud pascalgrimaud added this to the 7.2.0 milestone Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants