Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init sub generator #15491

Merged
merged 45 commits into from
Jul 1, 2021
Merged

Init sub generator #15491

merged 45 commits into from
Jul 1, 2021

Conversation

pascalgrimaud
Copy link
Member

Related to #15490


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the extensive review, but IMO this will make maintenance really easier.

@pascalgrimaud
Copy link
Member Author

Sorry for the extensive review, but IMO this will make maintenance really easier.

@mshima : forgot to thank you for the big review. Don't be sorry for helping me on this :)
I still got some questions to finish this
And if it's faster for you to commit and push directly to my branch, don't hesitate ! Just tell me

@mshima
Copy link
Member

mshima commented Jun 29, 2021

And if it's faster for you to commit and push directly to my branch,

I will do that, there are a few changes I think we should do.

@pascalgrimaud
Copy link
Member Author

pascalgrimaud commented Jun 29, 2021

And if it's faster for you to commit and push directly to my branch,

I will do that, there are a few changes I think we should do.

Thanks, I won't upgrade this branch, I let you apply the changes you have in mind.
I'm starting to upgrade my branch, related to the next sub generator (maven), to apply the changes you proposed here, to be consistent

@mshima
Copy link
Member

mshima commented Jun 29, 2021

@pascalgrimaud tell me if you don't like something.

@pascalgrimaud
Copy link
Member Author

Just crazy @mshima
It looks perfect. I'll do manual test tomorrow and merge it.
Again, thanks a lot

@pascalgrimaud
Copy link
Member Author

I got some error when testing it manually, related to git. It didn't manage to launch git init.
Then, because of that, npm run test test/init.spec.js failed too

09:23:09 in ~/tmp/01-beer 
➜ jhipster init
INFO! Using JHipster version installed globally
⬢ Welcome to the JHipster Init ⬢
? What is the project name of your application? Beautiful Beer Project
? What is the base name of your application? beer
? What is the default indentation? 2
? What is the Java indentation? 2
   create .prettierrc
   create .prettierignore
   create .gitignore
   create .gitattributes
   create .editorconfig
   create .huskyrc
   create package.json
    force .yo-rc.json
   create .lintstagedrc.js
   create README.md
WARNING! Failed to initialize Git repository.
 Error: fatal: ni ceci ni aucun de ses répertoires parents n'est un dépôt git : .git


Changes to package.json were detected.
Error detecting the package manager. Falling back to npm.

Running npm install for you to install the required dependencies.

added 152 packages, and audited 153 packages in 5s

30 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
WARNING! The generated application could not be committed to Git, as a Git repository could not be initialized.
Congratulations, JHipster execution is complete!
Sponsored with ❤️  by @oktadev.

09:23:26 in ~/tmp/01-beer took 16s 
➜ git log
fatal: ni ceci ni aucun de ses répertoires parents n'est un dépôt git : .git

@pascalgrimaud
Copy link
Member Author

Thanks @mshima !

@pascalgrimaud pascalgrimaud merged commit fe3d92f into jhipster:main Jul 1, 2021
@pascalgrimaud pascalgrimaud added this to the 7.2.0 milestone Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants