-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init sub generator #15491
Init sub generator #15491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the extensive review, but IMO this will make maintenance really easier.
@mshima : forgot to thank you for the big review. Don't be sorry for helping me on this :) |
I will do that, there are a few changes I think we should do. |
Thanks, I won't upgrade this branch, I let you apply the changes you have in mind. |
@pascalgrimaud tell me if you don't like something. |
Just crazy @mshima |
I got some error when testing it manually, related to git. It didn't manage to launch
|
Thanks @mshima ! |
Related to #15490
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.