Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump angular to 12.x #14980

Merged
merged 32 commits into from
Jun 1, 2021
Merged

Bump angular to 12.x #14980

merged 32 commits into from
Jun 1, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented May 13, 2021

Fix #13642

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima marked this pull request as draft May 13, 2021 10:13
…ators/client/templates/angular/angular/common-12.0.0

chore(deps): bump @angular/common from 11.2.13 to 12.0.0 in /generators/client/templates/angular
dependabot bot and others added 2 commits May 13, 2021 13:16
…ators/client/templates/angular/webpack-5.37.0

chore(deps-dev): bump webpack from 4.46.0 to 5.37.0 in /generators/client/templates/angular
@DanielFran DanielFran requested a review from kaidohallik May 19, 2021 07:28
@DanielFran
Copy link
Member

@mshima Is it missing anything or the PR is ready?

@mshima
Copy link
Member Author

mshima commented May 31, 2021

@DanielFran I am waiting for ng-bootstrap to support angular 12 so we could drop legacy-peer-deps option.

But we could merge as it is and drop later.

WDYT?

@DanielFran
Copy link
Member

DanielFran commented May 31, 2021

@mshima OK for me, let's merge!

@mshima mshima marked this pull request as ready for review May 31, 2021 17:42
@DanielFran DanielFran merged commit 563eb82 into main Jun 1, 2021
@DanielFran DanielFran deleted the angular12 branch June 1, 2021 07:57
@DanielFran DanielFran added area: enhancement 🔧 theme: angular theme: dependencies Pull requests that update a dependency file labels Jun 1, 2021
@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: enhancement 🔧 theme: angular theme: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to webpack 5 for Angular
3 participants