Implement workspaces generator. #14629
Conversation
|
blog-store test is failing due to a docker-compose regression related to #14563. |
.github/workflows/jdl.yml
Outdated
| run: echo "127.0.0.1 keycloak" | sudo tee -a /etc/hosts | ||
| - name: 'TESTS: packaging' | ||
| if: steps.tests-should-be-skipped.outputs.skip-tests != 'true' | ||
| run: npm run ci:e2e:package |
There was a problem hiding this comment.
I'd prefer to have package after test, because it is useless to package if tests failed lol
There was a problem hiding this comment.
The main reason for the this change is that it prevents a webpack build and probably reduces some seconds from backend tests too.
I plan to do the same for every workflow:
- Move package to be executed first
- Switch from
npm run ci:frontend:testtonpm run webapp:test
The workflow runtime reduces 1'30-3 minutes, 15-20% of the runtime.
There was a problem hiding this comment.
Reverted packaging to be after tests for now, if we are doing this change, let's do it later together.
generators/app/index.js
Outdated
| }); | ||
| } else { | ||
| this.warning('The generated application could not be committed to Git, as a Git repository could not be initialized.'); | ||
| let commitMsg = `Initial version of ${this.jhipsterConfig.baseName} generated by JHipster-${this.jhipsterConfig.jhipsterVersion}`; |
There was a problem hiding this comment.
Not related to this PR, but I think our initial commit is not nice. We should include the package name from official NPM repo, something like [email protected] so it can be easy to copy/paste etc
What do you think ?
What workspaces generator provides?
Closes #14272
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.