Use derived constant in entity-react generator #14628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Including correct bigdecimal support for react ;-). |
|
@deepu105 a little review please if you can, mshima already spent too much hours on similar ones and I don't want to get him bored :-). |
qmonmert
reviewed
Apr 9, 2021
...ty-client/templates/common/src/test/javascript/cypress/integration/entity/entity.spec.ts.ejs
Outdated
Show resolved
Hide resolved
qmonmert
reviewed
Apr 9, 2021
...ity-client/templates/react/src/test/javascript/e2e/entities/entity-update-page-object.ts.ejs
Outdated
Show resolved
Hide resolved
mshima
reviewed
Apr 10, 2021
...rators/entity-client/templates/react/src/main/webapp/app/entities/entity-reducer.spec.ts.ejs
Outdated
Show resolved
Hide resolved
generators/entity-client/templates/react/src/main/webapp/app/entities/entity.tsx.ejs
Outdated
Show resolved
Hide resolved
...ity-client/templates/react/src/test/javascript/e2e/entities/entity-update-page-object.ts.ejs
Outdated
Show resolved
Hide resolved
|
There are changes in the generated react code, I will let someone else say if the change is correct. |
|
The changes are on the bigdecimal handling: it looks like it was not supported in react before this update |
mshima
reviewed
Apr 10, 2021
...rators/entity-client/templates/react/src/main/webapp/app/entities/entity-reducer.spec.ts.ejs
Outdated
Show resolved
Hide resolved
…ntities/entity-reducer.spec.ts.ejs Co-authored-by: Marcelo Shima <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to #14235
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.