Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retrieve users authorities in user management page (reactive) #14484

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

chrisdns
Copy link
Member

fix #14475

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@chrisdns chrisdns force-pushed the fix-14475 branch 6 times, most recently from 3d8450a to bea4f4d Compare March 27, 2021 22:39
@pascalgrimaud
Copy link
Member

pascalgrimaud commented Mar 28, 2021

Is it possible to add an integration test in UserServiceIT plz? We shouldn't have this issue if there was a test for that

Anyway, thanks @chrisdns
cc @mraible @cbornet @murdos for the review of this important fix

@pascalgrimaud pascalgrimaud merged commit d7d17ac into jhipster:main Mar 29, 2021
@pascalgrimaud
Copy link
Member

I'm merging this as it's better than what we currently have, but still missing tests here

@chrisdns
Copy link
Member Author

@pascalgrimaud pascalgrimaud added this to the v7.0.1 milestone Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactive: user and authorities
3 participants