Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue: fix bootstrap variables #14457

Merged

Conversation

pascalgrimaud
Copy link
Member

Following #14306


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@pascalgrimaud pascalgrimaud changed the title Vue fix bootstrap variables Vue: fix bootstrap variables Mar 25, 2021
@pascalgrimaud pascalgrimaud merged commit cfdecb6 into jhipster:main Mar 25, 2021
@@ -5,6 +5,7 @@
* Make sure not to add !default to values here
*/

<%_ if (clientTheme === 'none') { _%>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use clientThemNone derived variable starting from now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, forgot about this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that many members will soon hate me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@qmonmert qmonmert mentioned this pull request Mar 25, 2021
5 tasks
@pascalgrimaud pascalgrimaud added this to the v7.0.1 milestone Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants