Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vue dependencies #13488

Merged
merged 7 commits into from
Jan 14, 2021
Merged

Update Vue dependencies #13488

merged 7 commits into from
Jan 14, 2021

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Jan 13, 2021

Fix #13466


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima
Copy link
Member

mshima commented Jan 13, 2021

@qmonmert a suggestion is to bump minor dependencies and move every dependency to package.json and let dependabot bump majors versions.
And this will keep vue updated.

@qmonmert qmonmert marked this pull request as ready for review January 13, 2021 15:39
@mshima
Copy link
Member

mshima commented Jan 13, 2021

I am not sure about protractor dependencies.
They are not covered by main tests (only covered by daily build), they may require to bisect to find a problematic update.

WDYT?
Otherwise looks good.

@qmonmert
Copy link
Contributor Author

@mshima & @mraible : I updated this PR with your returns

@mshima mshima merged commit 5ee85f1 into jhipster:main Jan 14, 2021
@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.1 milestone Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue dependencies need updating in 7.0 beta 0
4 participants