Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests next to the files they are testing in React #13425

Merged
merged 2 commits into from
Jan 10, 2021
Merged

Tests next to the files they are testing in React #13425

merged 2 commits into from
Jan 10, 2021

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Jan 7, 2021

Fix #13178


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@qmonmert qmonmert closed this Jan 8, 2021
@qmonmert qmonmert reopened this Jan 8, 2021
@qmonmert qmonmert closed this Jan 8, 2021
@qmonmert qmonmert reopened this Jan 8, 2021
@qmonmert
Copy link
Contributor Author

qmonmert commented Jan 8, 2021

@kaidohallik are you ok with that ? :)

@qmonmert
Copy link
Contributor Author

qmonmert commented Jan 9, 2021

@kaidohallik I did your changes requested

Copy link
Contributor

@kaidohallik kaidohallik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @qmonmert

@qmonmert qmonmert merged commit 134d4a2 into jhipster:main Jan 10, 2021
@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.1 milestone Jan 16, 2021
@kaidohallik kaidohallik mentioned this pull request Feb 7, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests next to the files they are testing in React
3 participants