-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[angular] Polish entity modules and update component #13318
Merged
mshima
merged 1 commit into
jhipster:main
from
kaidohallik:polish-angular-entity-module
Dec 17, 2020
Merged
[angular] Polish entity modules and update component #13318
mshima
merged 1 commit into
jhipster:main
from
kaidohallik:polish-angular-entity-module
Dec 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshima
approved these changes
Dec 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to follow angular documentation.
So let's merge it.
@kaidohallik : all JDL Microservices builds failed, since this PR. Can you have a look plz ?
|
I'm looking at that. |
5 tasks
Created #13322 for fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #12549 was changed entity module and entity update component.
In current draft PR #12971 entity module will be modified and entity update component changes are deleted.
For v7 beta release I propose to polish entity module and entity update component part with this PR. This PR follows suggestions from Angular module documentation: https://angular.io/guide/module-types
According to this documentation:
EntityRoutingModule
belongs to Routing module categoryEntityModule
belongs to Routed module categoryFor #12971 my suggestion is to split detail and update components into 2 different ones,
Component
+RoutedComponent
:Component
contains entity data related html and has@Input() entity: IEntity;
, for this component is created separate moduleComponentModule
which belongs to category Widget and whereComponent
is declaredRoutedComponent
html has header and footer and main part isComponent
from Widget module where attributeentity
has value read from route dataRoutedComponent
is declared inEntityModule
ComponentModule
is imported inEntityModule
, soComponent
is accesible inRoutedComponent
ComponentModule
imported andComponent
is available for usingping @mshima
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.