Generate applications without entities among a mixed list in JDL

[swarajsaaj]

Fixes bug to include applications with or without entities from the
config file, where applications without entities was ignored from a list
of applications with atleast one application with entities

Fix #13141

---

Please make sure the below checklist is followed for Pull Requests.

• All continuous integration tests are green
• Tests are added where necessary
• jhipster-online was updated if necessary
• Documentation is added/updated where necessary
• Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

[MathieuAA]

Something bothers me: the need to do this function. Are applications without entities filtered somewhere?
Furthermore, the test doesn't cover the entire flow: testing the JDL importer is also required

[swarajsaaj]

Something bothers me: the need to do this function. Are applications without entities filtered somewhere?
Furthermore, the test doesn't cover the entire flow: testing the JDL importer is also required

@MathieuAA The importState in jdl-importer.js is constructed from entitiesPerApplicationMap through JDLWithApplicationsToJSONConverter (see https://github.com/jhipster/generator-jhipster/blob/main/jdl/jdl-importer.js#L277)

The flow is such that this application-entity map is constructed fromJDLWithApplicationsToJSONConverter.convert, so rather than filtering out, these applications were not at all included in map (see https://github.com/jhipster/generator-jhipster/blob/main/jdl/converters/jdl-to-json/jdl-with-applications-to-json-converter.js#L49)

For test I agree, the test for jdl-importer should be added.

[MathieuAA]

Once the test is done, I think we should see things more clearly. Moreover, a test for the JDL cli command would be nice too!

[swarajsaaj]

Once the test is done, I think we should see things more clearly. Moreover, a test for the JDL cli command would be nice too!

@MathieuAA could you please explain what do you mean by 'JDL cli command' test, is it integration-test? or where are they located?

[MathieuAA]

In test/cli/jdl/import-jdl.spec.js

[pascalgrimaud]

@MathieuAA : if you feel confident, can we merge this for v7 ?

[MathieuAA]

Yes, let's do this

[swarajsaaj]

Bounty claim at https://opencollective.com/generator-jhipster/expenses/30284

[pascalgrimaud]

@swarajsaaj : approved

[MathieuAA]

@swarajsaaj great job :)

[swarajsaaj]

Thanks @MathieuAA :) . Thanks for all the help