Generate admin ui according to the flag value

[avdev4j]

Add a --with-admin-ui flag to generate the admin ui pages. By default, those pages are not generated and the user should use the JHipster Control Center application.

EDIT: add prompt instead

#12167
#12090

• Angular
• React
• Vue
• i18n
• JDL

---

Please make sure the below checklist is followed for Pull Requests.

• All continuous integration tests are green
• Tests are added where necessary
• jhipster-online was updated if necessary Add withAdminUi prompt in the generator form jhipster-online#257
• Documentation is added/updated where necessary JHipster Control Center Documentation jhipster.github.io#1026
• Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

[mraible]

Does this mean we're going to require two apps to run one app (if you want to administer the one app)?

[avdev4j]

Does this mean we're going to require two apps to run one app (if you want to administer the one app)?

Unless we use the flag I have added ;).

[MarlonLuan]

Typo

[pascalgrimaud]

I'm not totally in favor of this, for now.
I'd prefer to have no-admin-ui flag instead.

The reason is the JHipster Control Center is not finished yet today, and we don't have official lead on this. So it can become a dead project, if it's not well maintained.

[avdev4j]

I'm not totally in favor of this, for now.
I'd prefer to have no-admin-ui flag instead.

This was my main issue yesterday, Maybe we should add a question, something like (Would like to administrate your application with the JHipster Control Center?(the admin ui will be not generated) y/N".

Because if we add a flag like no-admin-ui I'm sure that nobody will use it :D?

With this question we will be able to add the JHCC Docker compose configuration only when the answer is "yes".

WDYT?

[PierreBesson]

I would say let's generate the jhcc docker compose all the time so people can try it out in any case... As for if the admin UI should be generated by default or not, I think it would be better to actually do a vote about it on the mailing list.

[pascalgrimaud]

It needs to be discussed, when admin ui is not choosen, should we keep swagger or not ?
I'd say:

• with admin ui: like today
• without admin ui: user-management + swagger

Swagger is so important, and it would not required too much maintenance !

[avdev4j]

after all, I think you're right @pascalgrimaud it's not a big effort to keep that so let's revert this changes.

[MathieuAA]

I've quickly reviewed the JDL part.
I'll do a more thorough review for this.

[avdev4j]

@MathieuAA I have tested many things and finally did not find the better way, except if we move to async functions.

Less code, easier to read and ofc less "PROMPT" ;).

I have added a commit, about that, in this PR but we can split into two different ones.

This is related to this PR: #12812

What do you think @mshima @sendilkumarn ?

[mshima]

LGTM.

2 non-blocker considerations:

• I would prefer --admin-ui instead of --with-admin-ui.
• httpsGet should be extracted into a util function instead of a generator-private member. Not the scope of this PR.

[MathieuAA]

That's a much better solution @avdev4j :)

[avdev4j]

• I would prefer --admin-ui instead of --with-admin-ui.

--with-admin-ui no longer exist because we move to a prompt instead of a flag.

• httpsGet should be extracted into a util function instead of a generator-private member. Not the scope of this PR.

Not scope in this PR but let rework the function to easily extract it in the future.

@mshima finally done, I think we can easily move the bootswatch functions to the prompt file to a lib.

[pascalgrimaud]

congrats for your hard work @avdev4j !

[pascalgrimaud]

lot of work done to achieve this, so increasing the bounty, it's well deserved

[avdev4j]

Bounty claimed https://opencollective.com/generator-jhipster/expenses/27873

[pascalgrimaud]

@avdev4j : approved