Merge pull request #26931 from mshima/parse-pom

keep xml tag value as string when parsing pom.xml

generators/maven/internal/xml-store.ts

@@ -25,10 +25,11 @@ const defaultXmlCommonOptions: Partial<X2jOptions & XmlBuilderOptions> = {
   ignoreAttributes: false,
   attributeNamePrefix: '@@',
   commentPropName: '#comment',
-  parseAttributeValue: false,
 };
 
 export const defaultXmlParserOptions: Partial<X2jOptions> = {
+  parseAttributeValue: false,
+  parseTagValue: false,
   ...defaultXmlCommonOptions,
 };
 

generators/maven/support/dependabot-maven.spec.ts

@@ -0,0 +1,49 @@
+/**
+ * Copyright 2013-2024 the original author or authors from the JHipster project.
+ *
+ * This file is part of the JHipster project, see https://www.jhipster.tech/
+ * for more information.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import { describe, expect } from 'esmocha';
+import { parseMavenPom } from './dependabot-maven.js';
+
+describe('parseMavenPom', () => {
+  it('should parse a pom file', () => {
+    const pomContent = `<?xml version="1.0" encoding="UTF-8"?>
+<project>
+    <artifactId>test</artifactId>
+    <version>1.0</version>
+    <properties>
+        <test.version>1.0</test.version>
+    </properties>
+</project>`;
+    const pom = parseMavenPom(pomContent);
+    expect(pom).toMatchInlineSnapshot(`
+{
+  "?xml": {
+    "@@encoding": "UTF-8",
+    "@@version": "1.0",
+  },
+  "project": {
+    "artifactId": "test",
+    "properties": {
+      "test.version": "1.0",
+    },
+    "version": "1.0",
+  },
+}
+`);
+  });
+});

generators/maven/support/dependabot-maven.ts

@@ -17,13 +17,14 @@
  * limitations under the License.
  */
 import { XMLParser } from 'fast-xml-parser';
+import { defaultXmlParserOptions } from '../internal/xml-store.js';
 
 /**
  * Extract properties from pom content
  * @param pomContent
  */
 export function getPomProperties(pomContent: string): Record<string, string> {
-  return new XMLParser().parse(pomContent).project.properties;
+  return new XMLParser(defaultXmlParserOptions).parse(pomContent).project.properties;
 }
 
 export type MavenPom = {
@@ -44,7 +45,7 @@ export type MavenPomAndVersions = {
  * @param fileContent
  */
 export function parseMavenPom(fileContent: string): MavenPom {
-  return new XMLParser().parse(fileContent);
+  return new XMLParser(defaultXmlParserOptions).parse(fileContent);
 }
 
 /**