Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Webex incoming webhook alerter #1635

Merged
merged 6 commits into from
Mar 6, 2025
Merged

Conversation

dennis-trapp
Copy link
Contributor

@dennis-trapp dennis-trapp commented Feb 27, 2025

Description

Adds alerter support for Webex incoming webhook

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@jertel
Copy link
Owner

jertel commented Mar 3, 2025

Thanks for submitting this. Do you anticipate other webex alerters at some point in the future? I'm asking since you named the new one webex_incoming vs webex.

@dennis-trapp
Copy link
Contributor Author

There's also a bot functionality for webex https://developer.webex.com/docs/bots and I could see it potentially being added in the future. However I am not too familiar with it as of this moment.

I am open to re-naming the alerter to whatever makes the most sense.

@jertel
Copy link
Owner

jertel commented Mar 4, 2025

Ok, if there's also a bot option then I agree it's better not to name it just webex. webex_webhook might be more clear but it's not that important.

@dennis-trapp
Copy link
Contributor Author

webex_webhook makes sense. I'll make that change.

@jertel jertel merged commit 55ccb06 into jertel:master Mar 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants