Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-35098] Work around core misfeature when using 1.642.x or 1.651.x #30

Merged
merged 1 commit into from
Oct 31, 2016

Conversation

jglick
Copy link
Member

@jglick jglick commented Oct 28, 2016

Pending an update to a core with jenkinsci/jenkins#2371 (or a backport), this should avoid a performance penalty observed from Stage View:

12345msec elapsed in Handling GET …/job/master/wfapi/runs …
    java.util.TreeMap.successor(TreeMap.java:2150)
    java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1208)
    java.util.TreeMap$KeyIterator.next(TreeMap.java:1261)
    nectar.plugins.rbac.groups.Group.isMatch(Group.java:472)
    nectar.plugins.rbac.groups.Group.isMatch(Group.java:425)
    nectar.plugins.rbac.groups.Group.isMatch(Group.java:362)
    nectar.plugins.rbac.groups.GroupContainerACL.hasPermission(GroupContainerACL.java:157)
    nectar.plugins.rbac.groups.GroupContainerACL._hasPermission(GroupContainerACL.java:106)
    nectar.plugins.rbac.groups.GroupContainerACL.hasPermission(GroupContainerACL.java:72)
    org.jenkinsci.plugins.workflow.multibranch.BranchJobProperty$1.hasPermission(BranchJobProperty.java:71)
    hudson.security.ACL.hasPermission(ACL.java:73)
    hudson.model.AbstractItem.hasPermission(AbstractItem.java:512)
    com.cloudbees.hudson.plugins.folder.AbstractFolder.getItems(AbstractFolder.java:581)
    hudson.model.Items.getAllItems(Items.java:357)
    hudson.model.Items.getAllItems(Items.java:377)
    hudson.model.Items.getAllItems(Items.java:377)
    hudson.model.Items.getAllItems(Items.java:353)
    jenkins.model.Jenkins.getAllItems(Jenkins.java:1444)
    hudson.scm.AutoBrowserHolder.infer(AutoBrowserHolder.java:77)
    hudson.scm.AutoBrowserHolder.get(AutoBrowserHolder.java:64)
    hudson.scm.SCM.getEffectiveBrowser(SCM.java:136)
    org.jenkinsci.plugins.workflow.job.WorkflowRun.getChangeSets(WorkflowRun.java:677)
    com.cloudbees.workflow.rest.external.ChangeSetExt.hasChanges(ChangeSetExt.java:149)
    com.cloudbees.workflow.rest.external.RunExt.createOld(RunExt.java:325)
    com.cloudbees.workflow.rest.external.RunExt.create(RunExt.java:304)
    com.cloudbees.workflow.rest.external.JobExt.create(JobExt.java:131)
    com.cloudbees.workflow.rest.endpoints.JobAPI.doRuns(JobAPI.java:72)

@reviewbybees esp. @svanoort

@ghost
Copy link

ghost commented Oct 28, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Copy link
Member

@svanoort svanoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me AFAICT

@jglick jglick merged commit 7ef365b into jenkinsci:master Oct 31, 2016
@jglick jglick deleted the getEffectiveBrowser-JENKINS-35098 branch October 31, 2016 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants