Use a watcher to monitor pod status while launching the agent #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossg
reviewed
Feb 12, 2019
| this.podStatus = pod.getStatus(); | ||
| switch (action) { | ||
| case MODIFIED: | ||
| if (areAllContainersRunning(pod)) { |
There was a problem hiding this comment.
do you need to check for terminated pods? otherwise if pod fails you will wait until the timeout instead of failing early
carlossg
approved these changes
Feb 18, 2019
jglick
reviewed
May 4, 2021
| // otherwise this method keeps being called multiple times | ||
| List<String> validStates = ImmutableList.of("Running"); | ||
|
|
||
| int waitForPodSec = cloud.getWaitForPodSec().intValue(); |
There was a problem hiding this comment.
This PR seems to have removed the one usage of a field introduced in #398 without removing the field itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the active wait by a proper watcher.
Submitting this to get the testing to run.