-
-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-75409] Write a core it test for -noCertificateCheck and -cert for inbound agents #10396
base: master
Are you sure you want to change the base?
[JENKINS-75409] Write a core it test for -noCertificateCheck and -cert for inbound agents #10396
Conversation
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
import org.jvnet.hudson.test.InboundAgentRule; | ||
import org.jvnet.hudson.test.RealJenkinsRule; | ||
|
||
public class TLSCustomCertificateTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build seems to be not having these certificate related options,
https://github.com/jenkinsci/jenkins-test-harness/blob/42ffa3423ed97d8d589c7ea26998325019b747f3/src/main/java/org/jvnet/hudson/test/InboundAgentRule.java#L96
I see there is some argument parsing in here,
https://github.com/jenkinsci/jenkins-test-harness/blob/42ffa3423ed97d8d589c7ea26998325019b747f3/src/main/java/org/jvnet/hudson/test/InboundAgentRule.java#L523-L529
but I am not able to understand if I can pass arguments like -noCertificateCheck
or -cert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my goal is to reproduce and later test passes after jenkinsci/remoting#786
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a five-second glance, I guess you would need to add an option to IAR to add custom agent arguments.
Missing required label for changelog. Requires at least 1 of: bug, developer, dependencies, internal, localization, major-bug, major-rfe, rfe, regression-fix, removed, skip-changelog. Found: tests. You can add the required label by adding a comment with the following text: |
This is downstream PR for jenkinsci/remoting#786
I am currently not able to understand how I can configure
-noCertificateCheck
and-cert
option to the InboundAgentRuleThis is draft PR to get help how to accomplish this.
See JENKINS-XXXXX.
Testing done
Proposed changelog entries
Proposed changelog category
/label
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist
upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).