Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guessBrowser fix to recognize more GitHub URLs #404

Merged
merged 2 commits into from
Jun 25, 2016

Conversation

jglick
Copy link
Member

@jglick jglick commented May 24, 2016

Buglet noticed while testing jenkinsci/jenkins#2371.

@reviewbybees

@KostyaSha
Copy link
Member

github-plugin had more fixes, probably compare regexpes?

@jglick
Copy link
Member Author

jglick commented May 24, 2016

github-plugin had more fixes

GitHubRepositoryName.URL_PATTERNS I suppose you mean?

As noted in a TODO comment nearby, I would really like to factor the guessing into an extension point. In the short term GithubWeb.GithubWebDescriptor could implement this, but that could perhaps be moved into github and share code with existing logic.

@ghost
Copy link

ghost commented Jun 16, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@MarkEWaite MarkEWaite merged commit 10733be into jenkinsci:master Jun 25, 2016
@MarkEWaite
Copy link
Contributor

I added support for ssh:// protocol form into the guesser and extracted the URL patterns out to a statically initialized array (as is done in github-pluign). I didn't add the extension point.

@jglick jglick deleted the guessBrowser branch August 8, 2016 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants