Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand error handling for reading tag files #199

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Conversation

mgarabed
Copy link
Contributor

@mgarabed mgarabed commented Apr 9, 2021

What does this PR do?

This adds more granular try/catch clauses plus logging statements to better handle errors when getting tag files.

Description of the Change

Check for more error conditions.

Alternate Designs

Possible Drawbacks

Pipeline jobs don't seem to report workspaces, meaning this feature may not even be working in those environments.

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@mgarabed mgarabed added the changelog/Fixed Fixed features results into a bug fix version bump label Apr 9, 2021
@FlorianVeaux FlorianVeaux merged commit 5d8ca9b into master Apr 12, 2021
@FlorianVeaux FlorianVeaux deleted the mg/read-tags-catch branch April 12, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Fixed Fixed features results into a bug fix version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants