Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve log message on incompatibilities when dd-java-agent is used as javaagent #185

Conversation

drodriguezhdez
Copy link
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

  • Improve log message on incompatibilities when dd-java-agent is used as javaagent

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@drodriguezhdez drodriguezhdez added the changelog/Fixed Fixed features results into a bug fix version bump label Feb 22, 2021
@drodriguezhdez drodriguezhdez force-pushed the drodriguezhdez/fail_gracefully_when_using_datadog_javaagent branch from fd4ace9 to f1f419c Compare February 22, 2021 12:27
@drodriguezhdez drodriguezhdez force-pushed the drodriguezhdez/fail_gracefully_when_using_datadog_javaagent branch from f1f419c to 993d218 Compare February 22, 2021 12:28
@drodriguezhdez drodriguezhdez merged commit 78f0e90 into master Feb 22, 2021
@drodriguezhdez drodriguezhdez deleted the drodriguezhdez/fail_gracefully_when_using_datadog_javaagent branch February 22, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Fixed Fixed features results into a bug fix version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants