Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[drop_yui] use jenkins button #498

Merged
merged 1 commit into from
Dec 18, 2024
Merged

[drop_yui] use jenkins button #498

merged 1 commit into from
Dec 18, 2024

Conversation

scherler
Copy link
Contributor

@scherler scherler commented Dec 18, 2024

Testing done

before
image
after
image

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Signed-off-by: Thorsten Scherler <[email protected]>
@scherler scherler requested a review from a team as a code owner December 18, 2024 09:09
@rsandell rsandell added the ui label Dec 18, 2024
@jglick
Copy link
Member

jglick commented Dec 18, 2024

Not sure if this monitor even still needs to exist; quite old. So presumably untested. 🤷

@jglick jglick merged commit c51412f into jenkinsci:master Dec 18, 2024
17 checks passed
@basil
Copy link
Member

basil commented Dec 18, 2024

So presumably untested. 🤷

FTR we did test it in #490, and the Testing Done section there shows how to reach the page.

@scherler scherler deleted the drop_yui branch December 19, 2024 09:45
@scherler
Copy link
Contributor Author

I added screenshots now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants