Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiserver support for web client #96

Merged
merged 6 commits into from
Feb 5, 2019
Merged

Add multiserver support for web client #96

merged 6 commits into from
Feb 5, 2019

Conversation

dkanada
Copy link
Member

@dkanada dkanada commented Jan 31, 2019

This enables multiserver support for the bundled web client for two reasons.

  1. Why hide an option for no reason?
  2. Some users may want this enabled.

This is exactly the same in Plex where you can select another server without leaving the current web frontend. I personally think this is useful, and it also works really well from the bundled frontend from my testing. I was able to switch between my dev and prod servers and the API calls were routed to the active server while the frontend calls were left on the current connection. I tested media playback, modifying user settings, and using the dashboard and everything worked fine for me.

JustAMan
JustAMan previously approved these changes Jan 31, 2019
Copy link
Contributor

@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Can you provide a screenshot what changes when we enable it on the web UI?

@hawken93
Copy link
Contributor

I'd like this to be something that could be decided by configuration at a later point :) for now I understand it's far easier to just enable it. LGTM

@dkanada dkanada changed the title add multiserver support for web client WIP: Add multiserver support for web client Feb 1, 2019
@dkanada
Copy link
Member Author

dkanada commented Feb 1, 2019

I want to make a few small changes before this gets merged to support running the web client on its own, should be done in a few days.

@JustAMan JustAMan dismissed their stale review February 2, 2019 13:07

Dismissing my review as this is tagged as WIP now

@dkanada
Copy link
Member Author

dkanada commented Feb 4, 2019

These changes will enable buttons to select a server in the user settings or navigation drawer for all web clients. All asset requests go to the hosted location regardless of the currently active server, and everything seems to be working fine. There shouldn't be any issues since this already works flawlessly on the Android client.

I have also implemented initial support for hosting the web client anywhere. I have been using nginx myself and it works great. The only change to get that working is adding the following two lines at the bottom of the index file. There is a single issue with a phantom server entry in the server selection page, but it has no effect on anything as far as I can tell.

<script src='scripts/apploader.js'></script>
<script>window.appMode='standalone';</script>

@dkanada dkanada changed the title WIP: Add multiserver support for web client Add multiserver support for web client Feb 4, 2019
Copy link
Contributor

@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM but one question.

@Bond-009 Bond-009 merged commit 0f96bb2 into jellyfin:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants