Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove games #80

Merged
merged 3 commits into from
Jan 31, 2019
Merged

Remove games #80

merged 3 commits into from
Jan 31, 2019

Conversation

cvium
Copy link
Member

@cvium cvium commented Jan 27, 2019

So in this PR I did touch the apiclient, but it's fairly minor and should be easy enough to replicate

@@ -201,7 +201,6 @@
"MessageNoDownloadsFound": "No s'han trobat descàrregues sense connexió. Descarrega mitjans per reproduir sense connexió emprant els botons de \"Descarrega\" que trobaràs per tota l'app.",
"MessageNoSyncJobsFound": "No s'han trobat descàrregues. Crea noves tasques de descàrrega emprant els botons de \"Descarrega\" que trobaràs per tota l'app.",
"MessageToValidateSupporter": "Si tens una subscripció activa d'Jellyfin Premiere assegura't que l'has configurat al teu tauler de control de l'Jellyfin Server, on pots accedir clicant a l'opció d'Jellyfin Premiere al menú principal.",
"MessageUnlockAppWithPurchaseOrSupporter": "Activa aquesta funcionalitat amb un únic pagament, o amb una subscripció activa d'Jellyfin Premiere.",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My search and replace apparently failed a bit, but it doesn't look like it removed anything of value in these strings files.

Copy link
Contributor

@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I would love to see de-uglification of touched files (in separate commit).
Didn't check all the languages, though.

@Bond-009 Bond-009 merged commit f523f33 into jellyfin:master Jan 31, 2019
@cvium cvium deleted the remove_games branch January 31, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants