Remove premiere stuff and fix crashes caused by earlier removals #8
Conversation
|
cc @JustAMan |
|
The last change here inadvertently broke the android client so I will be checking up again after this one to see what happens. Turns out there was some weird stuff going on in |
Co-Authored-By: cvium <[email protected]>
|
@JustAMan I haven't really bothered cleaning up the plugincatalogpage since I don't know if we're gonna keep it. Regarding the livetv indexes, I dunno. It seems it's throughout the dashboard ui that |
@JustAMan which ones? I couldn't find any. Maybe because I already force pushed? |
src/scripts/dashboardpage.js
Outdated
| if (session.TranscodingInfo && session.TranscodingInfo.TranscodeReasons && session.TranscodingInfo.TranscodeReasons.length) { | ||
| text.push("<br/>"); | ||
| text.push(globalize.translate("sharedcomponents#LabelReasonForTranscoding")); | ||
| showTranscodeReasons = true; |
There was a problem hiding this comment.
why not just insert the forEach loop from below here instead of a flag?..
src/scripts/dashboardpage.js
Outdated
| } | ||
|
|
||
| if (showTranscodeReasons) { | ||
| session.TranscodingInfo.TranscodeReasons.forEach(function (t__e) { |
There was a problem hiding this comment.
t__e seems a remaining stuff from de-ulglification
src/scripts/plugincatalogpage.js
Outdated
| } | ||
|
|
||
| function populateList(options) { | ||
| populateListInternal(options) | ||
| populateListInternal(options); | ||
| } | ||
|
|
||
| function getHeaderText(category) { | ||
| category.replace(" ", "").replace(" ", ""); |
There was a problem hiding this comment.
wtf does this double replace mean, isn't one enough?
There was a problem hiding this comment.
It's a no-op essentially. String.replace() returns a new string 🤷♂️
|
@JustAMan Done |
joshuaboniface
changed the title
This is the frontend part of jellyfin/jellyfin#412
Fixes jellyfin/jellyfin#122