Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Connect related from the frontend #79

Merged
merged 1 commit into from
Jan 30, 2019

Conversation

cvium
Copy link
Member

@cvium cvium commented Jan 27, 2019

Title says it all.

There's still a lot of leftover Connect code in connectionmanager.js, but it's in the apiclient and I won't touch it until it's been decided what to do about it (npm, submodule, whatever).

Copy link
Member

@anthonylavado anthonylavado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks safe to me.

Copy link
Contributor

@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question.

@JustAMan JustAMan merged commit d79a07d into jellyfin:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants