Fix firefox failing to set password for users with no password set #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawken93
changed the title
joshuaboniface
approved these changes
Jan 11, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes jellyfin/jellyfin#522
userpasswordpage.html has autocomplete=off on these fields, but firefox promptly ignores that.
This fix checks if the field is hidden and if so, then it doesn't submit it. The reason for it being so indirect is that I'm a noob and didn't know where a global variable for user.HasConfiguredPassword would be put..
I have hadded a descriptive comment to help anyone looking at this fix in the future.