Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic 404 page and *.html redirect #6601

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thornbill
Copy link
Member

Changes

  • Adds a basic 404 page and redirect for *.html paths when a match is not found

Screenshot 2025-03-12 at 17-18-53 Jellyfin

(A follow up PR will remove .html from all route paths.)

Issues
N/A

@thornbill thornbill added the enhancement Improve existing functionality or small fixes label Mar 12, 2025
@thornbill thornbill added this to the v10.11.0 milestone Mar 12, 2025
@thornbill thornbill requested a review from a team as a code owner March 12, 2025 21:20
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Mar 12, 2025

Cloudflare Pages deployment

Latest commit 6f670d5
Status ✅ Deployed!
Preview URL https://3b5a73f8.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

Copy link
Member

@viown viown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the stable app, the text is all the way at the left of the screen (not centered).

/* Fallback route for invalid paths */
{
path: '*',
Component: FallbackRoute
Copy link
Member

@viown viown Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refreshing the page does cause the header not to load. This is similar to an issue I fixed here, which in this case is likely caused by the page loading without the connection from ConnectionRequired being created.

On the experimental layout, the user profile gets hidden on refresh (like in your screenshot).

At a glance, I can't think of a good way to fix this other than possibly just removing the header (or hiding it) since this is a non-user route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants