Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix css fallback of max function in chrome 76. #6425

Conversation

bernarden
Copy link
Contributor

Changes
Fix css fallback of max function in chrome 76 by wrapping the usages in @supports statements.

Issues
#6422 and duplicates: #6357, #6420

@bernarden bernarden requested a review from a team as a code owner January 3, 2025 12:16
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Jan 3, 2025

Cloudflare Pages deployment

Latest commit 321822c
Status ✅ Deployed!
Preview URL https://99c93c7d.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@thornbill
Copy link
Member

It might make sense to use a mixin for this?

@bernarden bernarden force-pushed the bugfix/6422-unsupported-max-css-function-in-chrome-76 branch from a178811 to 49e0b95 Compare January 4, 2025 01:22
@bernarden bernarden force-pushed the bugfix/6422-unsupported-max-css-function-in-chrome-76 branch from 49e0b95 to 472b652 Compare January 4, 2025 02:27
@dmitrylyzo
Copy link
Contributor

dmitrylyzo commented Jan 4, 2025

Seems to work in Tizen 6 emulator.

I think we should fix this in 10.10.z

@dmitrylyzo dmitrylyzo added bug Something isn't working p: tizen This PR or issue mainly concerns Tizen clients ui & ux This PR or issue mainly concerns UI & UX labels Jan 4, 2025
@bernarden bernarden force-pushed the bugfix/6422-unsupported-max-css-function-in-chrome-76 branch from 472b652 to 072f066 Compare January 8, 2025 05:24
@bernarden bernarden changed the base branch from master to release-10.10.z January 8, 2025 05:26
@bernarden bernarden force-pushed the bugfix/6422-unsupported-max-css-function-in-chrome-76 branch from 072f066 to 321822c Compare January 8, 2025 05:28
Copy link

sonarqubecloud bot commented Jan 8, 2025

@dmitrylyzo dmitrylyzo added the stable backport Backport into the next stable release label Jan 8, 2025
@dmitrylyzo dmitrylyzo added this to the v10.10.4 milestone Jan 8, 2025
@thornbill thornbill merged commit d4b55ec into jellyfin:release-10.10.z Jan 10, 2025
15 checks passed
@bernarden bernarden deleted the bugfix/6422-unsupported-max-css-function-in-chrome-76 branch January 14, 2025 01:15
thornbill pushed a commit that referenced this pull request Jan 22, 2025
Fix css fallback of max function in chrome 76.

Original-merge: d4b55ec

Merged-by: thornbill <[email protected]>

Backported-by: thornbill <[email protected]>
@thornbill thornbill removed the stable backport Backport into the next stable release label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p: tizen This PR or issue mainly concerns Tizen clients ui & ux This PR or issue mainly concerns UI & UX
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants