Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent opus more than 2 channels being remuxed on Safari #6373

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

gnattu
Copy link
Member

@gnattu gnattu commented Dec 11, 2024

Safari only supports stereo Opus, which requires a similar workaround as we are applying on WebOS for FLAC.

This would currently force downmix 5.1 opus to stereo. After jellyfin/jellyfin#13209 landed in server the server will fallback to transcode 5.1 aac when source is 5.1 opus.

Changes

Issues

Safari only supports stereo Opus, which requires a similar workaround as we are applying on WebOS for FLAC.
@gnattu gnattu requested a review from a team as a code owner December 11, 2024 06:53
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Dec 11, 2024

Cloudflare Pages deployment

Latest commit 8f7974d
Status ✅ Deployed!
Preview URL https://16894472.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small remark.

@thornbill thornbill added enhancement Improve existing functionality or small fixes stable backport Backport into the next stable release playback This PR or issue mainly concerns playback labels Dec 29, 2024
@thornbill thornbill added this to the v10.10.4 milestone Dec 29, 2024
@thornbill thornbill merged commit 469abcc into jellyfin:release-10.10.z Dec 29, 2024
15 checks passed
thornbill pushed a commit that referenced this pull request Jan 22, 2025
Prevent opus more than 2 channels being remuxed on Safari

Original-merge: 469abcc

Merged-by: thornbill <[email protected]>

Backported-by: thornbill <[email protected]>
@thornbill thornbill removed the stable backport Backport into the next stable release label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes playback This PR or issue mainly concerns playback
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants