Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secondary audio on Tizen 8 #6317

Merged

Conversation

dmitrylyzo
Copy link
Contributor

@dmitrylyzo dmitrylyzo commented Nov 13, 2024

There are reports that additional audio track (AudioTrack API) doesn't work on Tizen 8.
Did Samsung break the AudioTrack API? 🤔

Changes
Don't use AudioTrack API on Tizen 8+.

Issues
Fixes jellyfin/jellyfin-tizen#293

@dmitrylyzo dmitrylyzo added bug Something isn't working p: tizen This PR or issue mainly concerns Tizen clients playback This PR or issue mainly concerns playback labels Nov 13, 2024
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Nov 13, 2024

Cloudflare Pages deployment

Latest commit a91e448
Status ✅ Deployed!
Preview URL https://3d94e63d.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@dmitrylyzo dmitrylyzo force-pushed the tizen8-no-secondary-audio branch from d1ac9d7 to a91e448 Compare November 27, 2024 12:21
@dmitrylyzo dmitrylyzo marked this pull request as ready for review November 27, 2024 12:22
@dmitrylyzo dmitrylyzo requested a review from a team as a code owner November 27, 2024 12:22
@dmitrylyzo
Copy link
Contributor Author

This may become unnecessary if Samsung fixes the AudioTrack API.

@kimahry
Copy link

kimahry commented Dec 4, 2024

Tested on my TV and it fixed my issue.
Will this be merged ?

@dmitrylyzo dmitrylyzo added the stable backport Backport into the next stable release label Dec 4, 2024
@dmitrylyzo dmitrylyzo added this to the v10.10.4 milestone Dec 4, 2024
@thornbill thornbill merged commit e15d700 into jellyfin:release-10.10.z Dec 29, 2024
14 checks passed
@dmitrylyzo dmitrylyzo deleted the tizen8-no-secondary-audio branch December 29, 2024 21:23
@Snuggerdog
Copy link

Still experiencing issues changing audio track after using the 10.10.z build. I select the alternate track plays in the original audio.

TV model Samsung Q70AA

thornbill pushed a commit that referenced this pull request Jan 22, 2025
Fix secondary audio on Tizen 8

Original-merge: e15d700

Merged-by: thornbill <[email protected]>

Backported-by: thornbill <[email protected]>
@thornbill thornbill removed the stable backport Backport into the next stable release label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p: tizen This PR or issue mainly concerns Tizen clients playback This PR or issue mainly concerns playback
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants