Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the intermediate notifications dashboard page #5761

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Remove the intermediate notifications dashboard page #5761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50d7ce8
cleanup: Remove the intermediate notifications dashboard page.
venkat-karasani Jul 8, 2024
63556e5
removed the unused translations from en-us.json
venkat-karasani Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/apps/dashboard/components/drawer/sections/AdvancedDrawerSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import Article from '@mui/icons-material/Article';
import EditNotifications from '@mui/icons-material/EditNotifications';
import ExpandLess from '@mui/icons-material/ExpandLess';
import ExpandMore from '@mui/icons-material/ExpandMore';
import Extension from '@mui/icons-material/Extension';
Expand Down Expand Up @@ -64,14 +63,6 @@ const AdvancedDrawerSection = () => {
<ListItemText primary={globalize.translate('TabLogs')} />
</ListItemLink>
</ListItem>
<ListItem disablePadding>
<ListItemLink to='/dashboard/notifications'>
<ListItemIcon>
<EditNotifications />
</ListItemIcon>
<ListItemText primary={globalize.translate('Notifications')} />
</ListItemLink>
</ListItem>
<ListItem disablePadding>
<ListItemLink to='/dashboard/plugins' selected={false}>
<ListItemIcon>
Expand Down
1 change: 0 additions & 1 deletion src/apps/dashboard/routes/_asyncRoutes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { AsyncRouteType, type AsyncRoute } from 'components/router/AsyncRoute';

export const ASYNC_ADMIN_ROUTES: AsyncRoute[] = [
{ path: 'activity', type: AsyncRouteType.Dashboard },
{ path: 'notifications', type: AsyncRouteType.Dashboard },
{ path: 'users', type: AsyncRouteType.Dashboard },
{ path: 'users/access', type: AsyncRouteType.Dashboard },
{ path: 'users/add', type: AsyncRouteType.Dashboard },
Expand Down
1 change: 0 additions & 1 deletion src/apps/dashboard/routes/_redirects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export const REDIRECTS: Redirect[] = [
{ from: 'metadataimages.html', to: '/dashboard/libraries/metadata' },
{ from: 'metadatanfo.html', to: '/dashboard/libraries/nfo' },
{ from: 'networking.html', to: '/dashboard/networking' },
{ from: 'notificationsettings.html', to: '/dashboard/notifications' },
{ from: 'playbackconfiguration.html', to: '/dashboard/playback/resume' },
{ from: 'repositories.html', to: '/dashboard/plugins/repositories' },
{ from: 'scheduledtask.html', to: '/dashboard/tasks/edit' },
Expand Down
34 changes: 0 additions & 34 deletions src/apps/dashboard/routes/notifications.tsx
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions src/strings/en-us.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,6 @@
"General": "General",
"Genre": "Genre",
"Genres": "Genres",
"GetThePlugin": "Get the Plugin",
"GoHome": "Go Home",
"GoogleCastUnsupported": "Google Cast Unsupported",
"GridView": "Grid View",
Expand Down Expand Up @@ -1147,8 +1146,6 @@
"Normal": "Normal",
"NoSubtitleSearchResultsFound": "No results found.",
"NoSubtitlesHelp": "Subtitles will not be loaded by default. They can still be turned on manually during playback.",
"Notifications": "Notifications",
"NotificationsMovedMessage": "The notifications functionality has moved to the Webhook plugin.",
"NumLocationsValue": "{0} folders",
"Off": "Off",
"OnApplicationStartup": "On application startup",
Expand Down
Loading