Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'how many times' is the speed of transcoding in Playback Info #5753

Merged
merged 8 commits into from
Aug 15, 2024
Merged

Add 'how many times' is the speed of transcoding in Playback Info #5753

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ae52916
feat: new display value for transcoding fps
iFraan Jul 7, 2024
2a3d743
fix: undefined safety + || instead of ??
iFraan Jul 8, 2024
145ed61
forgot to add to contributors
iFraan Jul 10, 2024
7d51c06
fix: apply suggestions
iFraan Jul 10, 2024
c9f6bde
chore: remove from contrib to rebase
iFraan Jul 25, 2024
1b22c19
rebase #1 from iFraan/master
iFraan Jul 25, 2024
0e60a0a
chore: add to contrib again
iFraan Jul 25, 2024
40cf514
Merge branch 'master' into add-x-to-playerstats-transcode-fps
thornbill Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/components/playerstats/playerstats.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ function getTranscodingStats(session, player, displayPlayMethod) {
if (session.TranscodingInfo.Framerate) {
sessionStats.push({
label: globalize.translate('LabelTranscodingFramerate'),
value: session.TranscodingInfo.Framerate + ' fps'
value: getDisplayTranscodeFps(session, player)
});
}
if (session.TranscodingInfo.TranscodeReasons?.length) {
Expand Down Expand Up @@ -191,6 +191,16 @@ function getDisplayBitrate(bitrate) {
}
}

function getDisplayTranscodeFps(session, player) {
const mediaSource = playbackManager.currentMediaSource(player) ?? {};
const videoStream = (mediaSource.MediaStreams ?? []).find((s) => s.Type === 'Video') ?? {};

const originalFramerate = videoStream.AverageFrameRate;
const transcodeFramerate = session.TranscodingInfo.Framerate;

return `${(transcodeFramerate / originalFramerate).toFixed(2)}x (${session.TranscodingInfo.Framerate} fps)`;
}

function getReadableSize(size) {
if (size >= 1073741824) {
return parseFloat((size / 1073741824).toFixed(1)) + ' GiB';
Expand Down
Loading