Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor search page #5607

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Refactor search page #5607

merged 4 commits into from
Jul 15, 2024
+656 −686

Conversation

grafixeyehero
Copy link
Member

@grafixeyehero grafixeyehero commented May 26, 2024 •
edited
Loading

Changes

  • Replace Legacy Api to new SDK API

@grafixeyehero grafixeyehero requested a review from a team as a code owner May 26, 2024 01:38
@thornbill
Copy link
Member

We haven't used any mui components in tv mode yet... do they work as expected?

@grafixeyehero
Copy link
Member Author

grafixeyehero commented May 26, 2024 •
edited
Loading

didn't test in actual tv.
if didn't work as we expected I will revert mui components change.

Search.tv.mode.mp4

@grafixeyehero grafixeyehero force-pushed the Refactor-Search--Page branch from e4570c9 to 4a050f6 Compare May 28, 2024 20:38
@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Jun 1, 2024
@jellyfin-bot

This comment has been minimized.

Sign in to view
@grafixeyehero grafixeyehero force-pushed the Refactor-Search--Page branch from 4a050f6 to a0fe3f8 Compare June 10, 2024 21:12
@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label Jun 10, 2024
@grafixeyehero
Refactor Search Page

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
9352ec1
@grafixeyehero
Remove unused component
Loading
Loading status checks…
01bad67
@grafixeyehero grafixeyehero force-pushed the Refactor-Search--Page branch from a0fe3f8 to 01bad67 Compare June 10, 2024 21:25
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@thornbill thornbill added needs testing This PR requires additional testing typescript PRs or issues relating to TypeScript code cleanup Cleanup of legacy code or code smells labels Jul 10, 2024
@grafixeyehero
Copy link
Member Author

@thornbill the last push was not include mui components change.

@thornbill thornbill removed the needs testing This PR requires additional testing label Jul 10, 2024
thornbill
thornbill reviewed Jul 15, 2024
View reviewed changes
thornbill
thornbill requested changes Jul 15, 2024
View reviewed changes
grafixeyehero and others added 2 commits July 15, 2024 22:13
@grafixeyehero @thornbill
revert translation key changes
13d5cb2 
Co-authored-by: Bill Thornton <[email protected]>
@grafixeyehero @thornbill
apply suggestion
fe31539 
Co-authored-by: Bill Thornton <[email protected]>
@thornbill thornbill added this to the v10.10.0 milestone Jul 15, 2024
@thornbill thornbill merged commit 0dfc095 into jellyfin:master Jul 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrylyzo dmitrylyzo

@thornbill thornbill

Assignees
No one assigned
Labels
cleanup Cleanup of legacy code or code smells typescript PRs or issues relating to TypeScript code
Projects
Jellyfin 10.10
Status: Done
Milestone
v10.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grafixeyehero @thornbill @jellyfin-bot @dmitrylyzo