Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter videos by audio stream language #43

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Filter videos by audio stream language #43

merged 1 commit into from
Jan 21, 2019

Conversation

taconaut
Copy link
Contributor

Uses and exposes the audio language filtering being added with this PR: jellyfin/jellyfin#624

It currently looks like this:
image

Show audio languages filter if any have been received in get filters call
Localized audio languages filter header in three languages
@taconaut taconaut changed the base branch from master to dev January 19, 2019 16:23
@dkanada
Copy link
Member

dkanada commented Jan 19, 2019

Does the key/value have to be added to every file?

It does for now, that was inherited from Emby. We would love to implement a decent i18n library, do you have any experience with that? Translations would definitely be easier with something like Weblate.

@taconaut
Copy link
Contributor Author

@dkanada unfortunately not, I'm a mainlya backend guy. It would be handy to have a fallback onto a default language, probably en-US.

@taconaut
Copy link
Contributor Author

It would be nice to also localize the language code.
Does the backend have any localization so it could return a tuple containing the language code along with the localized language name? Or is everything done in the frontend? (I'm dicovering the project ;)

Copy link
Member

@joshuaboniface joshuaboniface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me assuming merge conflicts in jellyfin/jellyfin#624 are fixed up.

@dkanada
Copy link
Member

dkanada commented Jan 20, 2019

Does the backend have any localization so it could return a tuple containing the language code along with the localized language name? Or is everything done in the frontend?

We have some very basic localization in the frontend, no clue about the backend. There must be some code somewhere to get the language name because I have seen it in a couple of locations in the server dashboard. One location is Dashboard -> Library -> Metadata if you want to do some digging. It would definitely be better to show the language name instead of the language code here.

@nvllsvm nvllsvm merged commit 412c53b into jellyfin:dev Jan 21, 2019
@joshuaboniface joshuaboniface mentioned this pull request Jan 21, 2019
@Oliver-Hanikel
Copy link

Oliver-Hanikel commented Sep 26, 2020

I'm a bit confused. The PR was merged but I can't find the language option on my Jellyfin 10.6.4.
image

@dkanada
Copy link
Member

dkanada commented Sep 26, 2020

We had to revert this because the backend portion was never finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants