-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter videos by audio stream language #43
Filter videos by audio stream language #43
Conversation
Show audio languages filter if any have been received in get filters call Localized audio languages filter header in three languages
It does for now, that was inherited from Emby. We would love to implement a decent i18n library, do you have any experience with that? Translations would definitely be easier with something like Weblate. |
@dkanada unfortunately not, I'm a mainlya backend guy. It would be handy to have a fallback onto a default language, probably en-US. |
It would be nice to also localize the language code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me assuming merge conflicts in jellyfin/jellyfin#624 are fixed up.
We have some very basic localization in the frontend, no clue about the backend. There must be some code somewhere to get the language name because I have seen it in a couple of locations in the server dashboard. One location is Dashboard -> Library -> Metadata if you want to do some digging. It would definitely be better to show the language name instead of the language code here. |
We had to revert this because the backend portion was never finished. |
Uses and exposes the audio language filtering being added with this PR: jellyfin/jellyfin#624
It currently looks like this:
