Remove broken features from web interface #37
Conversation
We should probably do a hard fork from jellyfin-archive/jellyfin-apiclient-javascript@c390d77 and publish it to npm or whatever. Then import with <favorite package manager>. |
dkanada
changed the title
|
Looking good :) |
| var infoHtml = responses[0]; | ||
| var downloadsHtml = responses[1]; | ||
|
|
||
| return new Promise(function (resolve, reject) { |
There was a problem hiding this comment.
Hmm, there's nothing to resolve these new promises unless I'm missing something.
There was a problem hiding this comment.
Yeah, turns out I had it right the first time. The promises were only made to call some external methods and they were resolved right here. Without the method calls the promises aren't necessary. I'll remove them in a minute.
There was a problem hiding this comment.
The way I see it there's two solutions. Removing the promises and not adding them to the promise array (this one you missed), or resolving them immediately. I prefer the former. Sorry I didn't suggest that instead...
There was a problem hiding this comment.
Isn't that what I did the first time though? I removed the promises and didn't return any values from those two methods.
There was a problem hiding this comment.
Check the current source for my original solution, I added it again.
There was a problem hiding this comment.
How about my latest commit? Removed the return statement so it just loads normally.
Co-Authored-By: dkanada <[email protected]>
|
Nice. LGTM now. |
joshuaboniface
changed the title
Several components in the javascript API don't have any source code available, including wakeonlan, serverdiscovery, cameraroll, and fileupload, which I assume was supposed to be a part of the
camerarollfeature. We might want to implementserverdiscoveryeventually, butwakeonlanandcamerarollshould be removed. I would also like to remove all sync related functionality and simply extend the download feature for mobile as well. I will list some reasons for these actions below that I mentioned in chat, but they are all my personal opinions so everything is open to discussion. My primary reason for removing these features is to make the code easier to maintain without losing any functionality.This is also a good time to ask what we are doing to sync the jellyfin-apiclient-javascript between its own repository and this project. I don't want to make changes here and then have to manually edit the other repository in the future.