Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct 404 on autoPlayDetect.js #291

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Correct 404 on autoPlayDetect.js #291

merged 1 commit into from
Apr 30, 2019

Conversation

bugfixin
Copy link
Contributor

Changes
This modifies a hardcoded reference to autoPlayDetect.js which has been renamed to autoplaydetect.js - because this is case sensitive it results in a 404.

Issues
Fixes #267

Copy link
Member

@dkanada dkanada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better option might be to rename the file to use camel casing, I think @vitorsemeano was moving to that in the webpack changes.

@bugfixin
Copy link
Contributor Author

Ah, I was just going for consistency as the majority of the other paths for js files are also lowercased, but I'd be just as happy with renaming the file to camelcase. It may also be worth merging this pull even if it is changed (along with all of the other js paths) to camelcase in the future.

@vitorsemeano
Copy link
Contributor

The reason is simple why I change some files to camel case. When the module is defined in site.js, the name is in camel case, pointing to the file on lower case. For webpack to solve automatically this files, you almost just need to change the filename to camel case, matching the definition found in site.js

@vitorsemeano
Copy link
Contributor

I don't change every module to camel case because I only change what webpack tells me he can't resolve. So is a case to case change. I will commit the webpack.config.js so you can see the state of webpack conversion.

@joshuaboniface joshuaboniface merged commit a6f942a into jellyfin:release-10.3.z Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants