Fix local chromecast play behind reverse proxy #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustAMan
approved these changes
Apr 1, 2019
|
Retargeted against release branch as RC hotfix. |
When using a HTTPS reverse proxy (for eg. traefik in fron of docker jellyfin), there's no valid advertised local address. Let's default to external one in such case, relying on the home router to properly route it internally.
agrenott
force-pushed
the
fix_chromcecast
branch
from
151b259 to
274ef0e
Compare
JustAMan
approved these changes
Apr 1, 2019
dkanada
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When using a HTTPS reverse proxy (for eg. traefik in fron of docker
jellyfin), there's no valid advertised local address.
Let's default to external one in such case, relying on the home router
to properly route it internally.
Issues
Fixes jellyfin/jellyfin#791 for me.