Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Chromecast volume instead while casting #219

Merged
merged 2 commits into from
Apr 1, 2019

Conversation

Froghut
Copy link
Contributor

@Froghut Froghut commented Mar 31, 2019

When changing volume connected to chromecast change the device volume instead of the jellyfin-player volume. This is more in line with other cast enabled apps.

Copy link
Member

@anthonylavado anthonylavado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me

Copy link
Contributor

@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending fixing my comments

@joshuaboniface joshuaboniface changed the base branch from master to release-10.3.z April 1, 2019 13:17
@joshuaboniface
Copy link
Member

Retargeted against release branch as RC hotfix.

@joshuaboniface joshuaboniface changed the title When changing volume connected to chromecast change the device volume… Change Chromecast volume instead while casting Apr 1, 2019
@JustAMan JustAMan merged commit f6f51d7 into jellyfin:release-10.3.z Apr 1, 2019
@Froghut Froghut deleted the chromecast_volume_fix branch April 2, 2019 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants