Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return inner promise in createConnectionManager #196

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Conversation

cvium
Copy link
Member

@cvium cvium commented Mar 17, 2019

Changes
The require didn't return anything which caused a race condition wherein the connection manager wouldn't always be loaded before execution continued after calling createConnectionManager. I've added a return to fix it.
Issues
Fixes this:

site.js?v=10.2.2:1587 Uncaught (in promise) ReferenceError: ConnectionManager is not defined
    at site.js?v=10.2.2:1587
    at Object.execCb (alameda.js?v=10.2.2:391)
    at defineModule (alameda.js?v=10.2.2:145)
    at main (alameda.js?v=10.2.2:346)
    at callDep (alameda.js?v=10.2.2:291)
    at waitForDep (alameda.js?v=10.2.2:177)
    at alameda.js?v=10.2.2:345
    at Array.forEach (<anonymous>)
    at main (alameda.js?v=10.2.2:343)
    at takeQueue (alameda.js?v=10.2.2:84)

@cvium cvium changed the title Return inner promise in init require Return inner promise in createConnectionManager Mar 17, 2019
@vitorsemeano
Copy link
Contributor

Very nice, one more problem solved, sorry if i didn't get that one, i am still somewhat fresh to this AMD approach.

@joshuaboniface joshuaboniface merged commit 1ae37fe into master Mar 18, 2019
@cvium cvium deleted the fix_promise branch March 18, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants