Re-add OpenSubtitles configuration page #136
Conversation
| <div> | ||
| <div class="content-primary"> | ||
| <form class="metadataSubtitlesForm"> | ||
| <div style="height:0; overflow: hidden;"><input type="text" name="fakeusernameremembered" tabindex="-1" /><input type="password" name="fakepasswordremembered" tabindex="-1" /></div> |
There was a problem hiding this comment.
I wonder what this is used for...
src/opensubtitles.html
Outdated
| <input is="emby-input" type="text" id="txtOpenSubtitleUsername" autocomplete="off" label="${LabelOpenSubtitlesUsername}" /> | ||
| <div class="fieldDescription"> | ||
| <!-- TODO missing ${ButtonRegister} --> | ||
| <a is="emby-linkbutton" class="button-link" target="_blank" href="http://www.opensubtitles.org/">Register</a> |
There was a problem hiding this comment.
Why it's an <a>, not a <button> like other "Save" button below?
There was a problem hiding this comment.
Anywhere with a link just loads a separate page with no other background tasks, while buttons are for API calls or other stuff besides the page load.
There was a problem hiding this comment.
Thank you for explanation.
I feel this should be somewhere in UX docs... cc @nvllsvm
There was a problem hiding this comment.
This isn't necessarily a coding style, just something I noticed in the codebase. It makes sense to use a simple link when you just need to load a separate page.
There was a problem hiding this comment.
Not a coding, but a UX style. So our user experience is consistent :)
Fixes jellyfin/jellyfin#860