-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure a single leading @
for twitter usernames
#367
Conversation
This prevents destroying the template due to the incorrect use of quotes.
Did you know?Liquid also has a |
I did not know. However, I have taken the Replace from the previous version. |
I understand that. But since the lines are being updated, its always best to use the most apt route. |
Replaced `replace` with `remove`
@
for twitter usernames
Done |
Thanks for updating. Do you by any chance know if |
Sorry, as far as I know the first @ is required, but if additional @ are allowed, I don't know |
https://help.twitter.com/en/managing-your-account/twitter-username-rules It's not allowed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid unnecessary String allocations.. (Certain Liquid filters duplicate the input string before processing it.)
Done |
A test could be helpful so we don't regress in the future! |
@jekyllbot: merge +minor |
This prevents destroying the template due to the incorrect use of quotes.